Google Git
Sign in
chromium / chromium / src / 5d5a28cd0bd12dd79c87640a34974beb84faf589
commit5d5a28cd0bd12dd79c87640a34974beb84faf589[log] [tgz]
authorDaniel Cheng <dcheng@chromium.org>Sat Mar 16 09:00:03 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Mar 16 09:00:03 2024
tree20e1097ecf7ff9ce51892ab80a7b91a5722534f3
parent5435aaaf95556df2e15764e938f1b66372c9ba13 [diff]
Revert "Record metrics for drive suggestion subtypes"

This reverts commit 9fd5e2ef04bbcf87635639b2858ab4179a289d06.

Reason for revert: Causing CHECK failures when recording histograms.
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/56757/overview

Original change's description:
> Record metrics for drive suggestion subtypes
>
> To get better idea of what kind of drive suggestions users launch from
> continue section, record impressions and user actions for different
> types of drive and local file suggestions. To support this, pipe down
> the files' justification types (currently used only to generate
> justification strings) to app list search result type (as result
> subtypes), and record the result subtypes with other app list search
> impression metrics.
>
> BUG=b/316180378
>
> Change-Id: I5947090fce04a289bfa7ac082d1e650d37e79def
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373824
> Reviewed-by: Yulun Wu <yulunwu@chromium.org>
> Commit-Queue: Toni Barzic <tbarzic@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1273640}

Bug: b/316180378
Change-Id: Id25f1f71d2bede8823755f5ca9acd1fd0748b234
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5375729
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273804}
31 files changed
tree: 20e1097ecf7ff9ce51892ab80a7b91a5722534f3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.