Google Git
Sign in
chromium / chromium / src / 5d698dd55214eaf6d396527f9f23c03009b0ee9c
commit5d698dd55214eaf6d396527f9f23c03009b0ee9c[log] [tgz]
authorChristopher Cameron <ccameron@chromium.org>Fri Feb 21 17:26:11 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 21 17:26:11 2025
treeac6e0a4696cff876dbc09d295fc8799c78e3625e
parent6f1d34956a4f8cb0f225bdf264d2b849b32c6ec2 [diff]
GetSourceImageForCanvas: Use kDoNotChangeAlpha in VideoFrame

Change the use of GetSourceImageForCanvas in VideoFrame::Create to not
request an eager conversion to premultiplied alpha.

media::VideoFrame does not track whether or not the alpha channel is
premultiplied. It is implicitly unpremultiplied for YUVA formats. For
RGBA formats, it seems to be implicitly premultiplied.

If the source's image is accelerated and unpremultiplied (which never
happens today, but might one day be enabled), fall back to the software
path.

In the software path, perform an eager conversion to unpremultiplied
format. This preserves the existing behavior prior to this change (and
does not address the question of media::VideoFrame tracking of alpha
type).

Bug: 40277213
Change-Id: Icf2d421eb5d364c524bfdfc97dcb4a6b3503acf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6281097
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1423212}
1 file changed
tree: ac6e0a4696cff876dbc09d295fc8799c78e3625e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.