Google Git
Sign in
chromium / chromium / src / 5d6ed70687fb808dcadf78cfb4b718477f1c246a
commit5d6ed70687fb808dcadf78cfb4b718477f1c246a[log] [tgz]
authorDevlin Cronin <rdevlin.cronin@chromium.org>Fri Oct 27 23:13:06 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Oct 27 23:13:06 2023
treea7d00a46768f363ed89f66a1013c9f8b25732ed8
parent72517f83ab65c0fe99106bf71c3332c3fb40eaba [diff]
[Extensions] Toggle registered user scripts according to dev mode

The userScripts API is gated on the user being in developer mode. If
the user exits developer mode, any registered user scripts should no
longer run.

Add support for disabling and re-enabling these user scripts when the
user enters or exits dev mode. Note that this deliberately does *not*
remove the scripts from the storage in
`ExtensionUserScriptLoader::loaded_dynamic_scripts_` and only removes
them from the base `UserScriptLoader` (which notifies all renderers
appropriately). This ensures that when subsequent updates and writes
occur, the user scripts are still correctly persisted in the database
and makes re-enabling them simple.

A future CL will properly initialize the enabled state of user scripts
on browser startup and ExtensionUserScriptLoader initialization.

Bug: 1495451
Change-Id: If0380b1df794f74567d3ff5e04497f68649ad01e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4984712
Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Emilia Paz <emiliapaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1216434}
10 files changed
tree: a7d00a46768f363ed89f66a1013c9f8b25732ed8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.