commit 5d76fbfb5112c402da93c27afb661f5974920ab1
author manukh <manukh@chromium.org> Thu Sep 18 22:42:58 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Sep 18 22:42:58 2025
tree 9fc133521503b6be953fa299910eaf53367ed86b
parent fc98c43191c68c608ca2536a8857ee1d8a094c23

[omnibox][webui] Don't crash when focusing RHS AI button

Realbox handler maps the omnibox selection state enum to a mojom enum.
It didn't know what to do with a `LineState::FOCUSED_BUTTON_AIM`.

Bug: 445995099
Change-Id: I11cef81bc936385d84707072e588d832ce020b5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6967401
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Auto-Submit: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Khalid Peer <khalidpeer@chromium.org>
Commit-Queue: Khalid Peer <khalidpeer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1517613}

chrome/browser/ui/webui/searchbox/realbox_handler.cc

diff --git a/chrome/browser/ui/webui/searchbox/realbox_handler.cc b/chrome/browser/ui/webui/searchbox/realbox_handler.cc
index a826501..4b1ae39 100644
--- a/chrome/browser/ui/webui/searchbox/realbox_handler.cc
+++ b/chrome/browser/ui/webui/searchbox/realbox_handler.cc
@@ -55,6 +55,7 @@
 #include "ui/base/window_open_disposition_utils.h"
 
 namespace {
+
 class RealboxOmniboxClient final : public SearchboxOmniboxClient {
  public:
   RealboxOmniboxClient(Profile* profile, content::WebContents* web_contents);
@@ -82,6 +83,28 @@
                        profile_metrics::GetBrowserProfileType(profile_));
 }
 
+searchbox::mojom::SelectionLineState ConvertLineState(
+    OmniboxPopupSelection::LineState state) {
+  switch (state) {
+    case OmniboxPopupSelection::LineState::NORMAL:
+      return searchbox::mojom::SelectionLineState::kNormal;
+    case OmniboxPopupSelection::LineState::KEYWORD_MODE:
+      return searchbox::mojom::SelectionLineState::kKeywordMode;
+    case OmniboxPopupSelection::LineState::FOCUSED_BUTTON_AIM:
+      // WebUi currently only cares about popup matches' selection states. No
+      // need to pipe in a selection state that's unique to the omnibox input.
+      return searchbox::mojom::SelectionLineState::kNormal;
+    case OmniboxPopupSelection::LineState::FOCUSED_BUTTON_ACTION:
+      return searchbox::mojom::SelectionLineState::kFocusedButtonAction;
+    case OmniboxPopupSelection::LineState::FOCUSED_BUTTON_REMOVE_SUGGESTION:
+      return searchbox::mojom::SelectionLineState::
+          kFocusedButtonRemoveSuggestion;
+    default:
+      // Realbox doesn't support the other UIs and their focus states.
+      NOTREACHED() << state;
+  }
+}
+
 }  // namespace
 
 RealboxHandler::RealboxHandler(
@@ -163,23 +186,6 @@
                               disposition);
 }
 
-searchbox::mojom::SelectionLineState ConvertLineState(
-    OmniboxPopupSelection::LineState state) {
-  switch (state) {
-    case OmniboxPopupSelection::LineState::NORMAL:
-      return searchbox::mojom::SelectionLineState::kNormal;
-    case OmniboxPopupSelection::LineState::KEYWORD_MODE:
-      return searchbox::mojom::SelectionLineState::kKeywordMode;
-    case OmniboxPopupSelection::LineState::FOCUSED_BUTTON_ACTION:
-      return searchbox::mojom::SelectionLineState::kFocusedButtonAction;
-    case OmniboxPopupSelection::LineState::FOCUSED_BUTTON_REMOVE_SUGGESTION:
-      return searchbox::mojom::SelectionLineState::
-          kFocusedButtonRemoveSuggestion;
-    default:
-      NOTREACHED();
-  }
-}
-
 void RealboxHandler::UpdateSelection(OmniboxPopupSelection old_selection,
                                      OmniboxPopupSelection selection) {
   page_->UpdateSelection(