Google Git
Sign in
chromium / chromium / src / 5d7b752664d80a8ded3a32e9ada011cd81e233d1
commit5d7b752664d80a8ded3a32e9ada011cd81e233d1[log] [tgz]
authorOlivia Saul <jsaul@google.com>Wed Oct 02 18:43:13 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Oct 02 18:43:13 2024
tree6c6bdac8889802a56f711b348bee96ac59053bbd
parentd2d93692d6fec3d7e328a714342d167263e34e98 [diff]
[AF] Clean up 40 incorrect histogram resolutions

SaveCreditCardPrompt[Offer|Result] should not be able to have blank
entries for its first two variant tokens. This CL removes them, cleaning
up 40 entries that the UMA dashboard otherwise makes selectable.

This is only step 1 in my long-term goal of A) cleaning up our histogram
entries, B) keeping periods out of variants, and C) maybe keeping blank
values out of variants as well (depending on how cluttered it ends up).

None of these histograms have any data because they are not used:
https://uma.googleplex.com/p/chrome/timeline_v2?sid=2229edd9243fbf20d98ceb82293ba1a2

The histograms being removed are as follows:

Autofill.SaveCreditCardPromptOffer
Autofill.SaveCreditCardPromptOffer.FirstShow
Autofill.SaveCreditCardPromptOffer.FirstShow.RequestingCardholderName
Autofill.SaveCreditCardPromptOffer.FirstShow.RequestingExpirationDate
Autofill.SaveCreditCardPromptOffer.FirstShow.SavingWithCvc
Autofill.SaveCreditCardPromptOffer.Local
Autofill.SaveCreditCardPromptOffer.Local.RequestingCardholderName
Autofill.SaveCreditCardPromptOffer.Local.RequestingExpirationDate
Autofill.SaveCreditCardPromptOffer.Local.SavingWithCvc
Autofill.SaveCreditCardPromptOffer.RequestingCardholderName
Autofill.SaveCreditCardPromptOffer.RequestingExpirationDate
Autofill.SaveCreditCardPromptOffer.Reshows
Autofill.SaveCreditCardPromptOffer.Reshows.RequestingCardholderName
Autofill.SaveCreditCardPromptOffer.Reshows.RequestingExpirationDate
Autofill.SaveCreditCardPromptOffer.Reshows.SavingWithCvc
Autofill.SaveCreditCardPromptOffer.SavingWithCvc
Autofill.SaveCreditCardPromptOffer.Upload
Autofill.SaveCreditCardPromptOffer.Upload.RequestingCardholderName
Autofill.SaveCreditCardPromptOffer.Upload.RequestingExpirationDate
Autofill.SaveCreditCardPromptOffer.Upload.SavingWithCvc
Autofill.SaveCreditCardPromptResult
Autofill.SaveCreditCardPromptResult.FirstShow
Autofill.SaveCreditCardPromptResult.FirstShow.RequestingCardholderName
Autofill.SaveCreditCardPromptResult.FirstShow.RequestingExpirationDate
Autofill.SaveCreditCardPromptResult.FirstShow.SavingWithCvc
Autofill.SaveCreditCardPromptResult.Local
Autofill.SaveCreditCardPromptResult.Local.RequestingCardholderName
Autofill.SaveCreditCardPromptResult.Local.RequestingExpirationDate
Autofill.SaveCreditCardPromptResult.Local.SavingWithCvc
Autofill.SaveCreditCardPromptResult.RequestingCardholderName
Autofill.SaveCreditCardPromptResult.RequestingExpirationDate
Autofill.SaveCreditCardPromptResult.Reshows
Autofill.SaveCreditCardPromptResult.Reshows.RequestingCardholderName
Autofill.SaveCreditCardPromptResult.Reshows.RequestingExpirationDate
Autofill.SaveCreditCardPromptResult.Reshows.SavingWithCvc
Autofill.SaveCreditCardPromptResult.SavingWithCvc
Autofill.SaveCreditCardPromptResult.Upload
Autofill.SaveCreditCardPromptResult.Upload.RequestingCardholderName
Autofill.SaveCreditCardPromptResult.Upload.RequestingExpirationDate
Autofill.SaveCreditCardPromptResult.Upload.SavingWithCvc

Bug: 335030020
Change-Id: I9092dc5fbe8f6fe2ffffea01e158dcdd31ffc7c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5896356
Commit-Queue: Olivia Saul <jsaul@google.com>
Reviewed-by: Vinny Persky <vinnypersky@google.com>
Cr-Commit-Position: refs/heads/main@{#1363200}
1 file changed
tree: 6c6bdac8889802a56f711b348bee96ac59053bbd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.