Avoid PseudoStateChanged call during HTMLInputElement construction. DidNotifySubtreeInsertionsToDocument() is called during the process of inserting an element into the document. Prior to this change HTMLInputElement's implementation calls ListAttributeTargetChanged(). This change makes it instead only do one of the two things that ListAttributeTargetChanged() does, since the other (PseudoStateChanged()) is unnecessary since there has been no *change* to the pseudo state. This avoids the cost of computing the style changes involved. This was found in a profile of the Speedometer3 subtest TodoMVC-jQuery/CompletingAllItems, on which it is a 2% win. It also appears to be about a 0.5% win on TodoMVC-Javascript-ES5 and TodoMVC-Javascript-ES6-Webpack-Complex-DOM (where it also shows up in the profiles). Change-Id: Ie76c13b6fe6eccb421a78c388582c7f5a3b4662a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6174303 Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Di Zhang <dizhangg@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1406805}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.