Google Git
Sign in
chromium / chromium / src / 5da4e6b354b93cf178360a739f093ef013ba811e
commit5da4e6b354b93cf178360a739f093ef013ba811e[log] [tgz]
authorTsuyoshi Horo <horo@chromium.org>Thu Jul 24 23:50:53 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 24 23:50:53 2025
treec485aa6b69c30a5c21376e187f374d6b75f5eda1
parent30e2465197e91d73ee892cf88e54ee6a2bff42b0 [diff]
disk_cache/sql: Add startup cleanup for stale doomed entries

When a cache entry is doomed, it is marked for deletion in the database.
If the browser crashes before the entry is physically deleted,
the entry's data can be left behind, consuming disk space indefinitely.

This change introduces a one-time cleanup task that runs after the SQL
backend is initialized. After a delay (to avoid impacting startup
performance), this task identifies and deletes all entries that were
marked as "doomed" in previous sessions.

To prevent data corruption, the cleanup task excludes any entries that
are currently held as "active doomed" in the live backend. This ensures
that entries doomed in the current session, which may still have active
handles, are not prematurely deleted.

A unit test is added to simulate a crash scenario and verify that the
cleanup mechanism correctly removes the stale entry while preserving
active doomed entries.

Bug: 422065015
Change-Id: Ia220a21d8dfa9f6404c380a404caa3135a0da563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6773708
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Mingyu Lei <leimy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491753}
4 files changed
tree: c485aa6b69c30a5c21376e187f374d6b75f5eda1
  1. .github/
  2. agents/
  3. android_webview/
  4. apps/
  5. ash/
  6. base/
  7. build/
  8. build_overrides/
  9. buildtools/
  10. cc/
  11. chrome/
  12. chromecast/
  13. chromeos/
  14. codelabs/
  15. components/
  16. content/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. net/
  33. pdf/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. clusterfuzz-data
  51. internal
  52. ios_internal
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .cursorignore
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.