Google Git
Sign in
chromium / chromium / src / 5db31b51f232cfd6b7b99a8919e739c7c45d0f55
commit5db31b51f232cfd6b7b99a8919e739c7c45d0f55[log] [tgz]
authorLouis Romero <lpromero@google.com>Fri Jul 28 09:10:31 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jul 28 09:10:31 2023
tree005cfb574d5d071595b72e985ab5913d20edf9b9
parent5c2f97b308178e4b9ab1a0fc35c93660f3aa2d77 [diff]
Add lpromero as tab_grid owner

I contributed 2^7 commits to tab_grid over the past year:

ea6f4390c0a50 23/07/28 Use cell and supplementary view registration in
                       GridViewController
74562fa190f49 23/07/26 Remove iOS 14 and below code paths related to
                       tab grid
3afd223df0063 23/07/26 Add configuration helpers
d5c649d005702 23/07/26 Remove iOS 14 and below code paths related to
                       key commands
aeb039b95fe11 23/07/26 Don't add pointer interaction to the suggested
                       actions cell
3410106fbf96a 23/07/26 Remove cell's zPosition as it was for
                       thumbstrip
2b2c036dd419e 23/07/26 Move accessibility identifier to the cell
                       donfiguration method
937c16bb79873 23/07/25 Ignore tab grid taps when the grids are not the
                       current page
a94373ec89f1d 23/07/24 Remove unnecessary imports of named_guide.h
e1dc61c984a03 23/07/24 Migrate to Diffable Data Source in
                       GridViewController
264d933fd08d0 23/07/24 Add DumpWithoutCrashing to see if API is called
                       incorrectly
7c75c39575565 23/07/24 Add lpromero in GridViewController's OWNERS
3d80d21529cac 23/07/24 Add helpers to avoid multi-statement blocks
66b0b00ccbd43 23/07/24 Refactor selected item ring updates
68ec51233faea 23/07/21 Clean up a private GridViewController API
a75a432aae815 23/07/20 Fix selection ring animation
cdb8a2d66e108 23/07/20 Move code around
b0d62fbcdac55 23/07/20 Remove a CHECK that can be false
51d14bb440141 23/07/07 Add strongSelf to GridViewController where
                       needed
75b049842ff81 23/06/21 Nicer anim when closing the last inactive tab
213b18060874b 23/06/12 Improve Snapshot ID APIs
bb1e7237694fc 23/06/09 Identify a webstate by its snapshot ID when
                       snapshot is updated
75ed947c41a16 23/06/07 Remove DumpWithoutCrashing in
                       reportTabSelectionTime
eeba31c551995 23/06/06 Don't record tab grid exit metrics at launch
431e65e6728be 23/06/03 Support batch operations of the
                       TabRestoreService in Recent Tabs
17590142a21ca 23/06/02 Add EG tests for Inactive Tabs
ba412756e7423 23/05/27 Add Tab Grid Recency sort EG test
510c4a67ec65c 23/05/25 Add EG tests for Inactive Tabs
fe6ef6595dc01 23/05/25 Add utils for Tab Grid related EG tests
3f0b57c8b395e 23/05/25 Add the sizing header to the view hierarchy
712af07c3e7c0 23/05/25 Use absl::optional instead of std::unique_ptr
511d8b2fee86b 23/05/25 Fix Tab Grid Search to Reading List EG test
a138c1d2a3caa 23/05/25 Migrate from sizeCategory to dynamicTypeSize
4bda5f17f3250 23/05/24 Rename ScrollingTimeLogger in
                       ScopedScrollingTimeLogger
15cbe1e32f4bd 23/05/24 Don't keep Inactive Tabs VC in memory
98f022bc38113 23/05/23 Small cleanup in Tab Grid classes
08b823bc274bd 23/05/23 Improve Close All Inactive animation
a5796aa8ea6a9 23/05/17 Add InactiveTabs user metrics
cc86062f74b10 23/05/16 Don't crash when the Tab Grid enter time was
                       not recorded
c5d211d581464 23/05/09 Fix horizontal insets in Inactive Tabs grid
fa035f5774844 23/05/05 Enable tab-grid-recency-sort in field trials
2b7532deef4a7 23/05/05 Use IsInactiveTabsAvailable instead of
                       IsInactiveTabsEnabled
e7e675b84501a 23/05/02 Add edge-swipe to Inactive Tabs
4d787c6bdcb13 23/04/28 Don't immediately pop when emptying Inactive
                       Tabs via settings
1c18d2ddb4dca 23/04/28 Create Inactive Tabs classes when feature is
                       available
5fcb91263b8c9 23/04/28 Improve the features-related methods for
                       Inactive Tabs
9b10395683174 23/04/28 Remove unnecessary command
285d8d0bc5dfe 23/04/27 Measure the time spent opening an existing tab
63e25d1967240 23/04/27 Add scrolling metrics in grid views
e8b30d4d2a6da 23/04/26 Let TabSwitcherItem be snapshot data source in
                       Tab Grid
042b0d4205b4b 23/04/25 Use constants instead of inlined values
129a1141ee19e 23/04/25 Reorder scrollview delegate methods
46371132676e2 23/04/24 Fix the padding around the Inactive Tabs button
cc782257f1e8a 23/04/24 Nicer animation to show/hide Inactive Tabs
64cbee86842b6 23/04/22 Add a `showing` property to
                       InactiveTabsCoordinator
2465b33bdce45 23/04/21 Fix Inactive Tabs UI details
5bd5195d02d31 23/04/20 Fix Inactive Tabs button highlighted color
9d04e6afcbf6c 23/04/20 Use InactiveTabsTimeThreshold() instead of
                       reading the pref
fcc8e0eb71e99 23/04/20 Early return when trying to Close All Inactive
                       while 0 tabs
c40eb3c758c5e 23/04/20 Close Inactive Tabs view when closing the last
                       inactive tab
cfbf53a963d4a 23/04/20 Fix layouts of Inactive Tabs UIs
efe9cce952ced 23/04/20 Improve Inactive Tabs accessibility
45e760e18ee40 23/04/18 Let TabSwitcherItem be snapshot data source
                       with Inactive Tabs
45aa2d1dbdddc 23/04/18 Let TabSwitcherItem be snapshot data source
                       with Pinned Tabs
44aec5041cfa6 23/04/18 Let TabSwitcherItem be favicon data source in
                       Tab Switcher UI surfaces
f94bdc69793aa 23/04/18 Fix Dynamic Type support in Inactive Tabs
                       preamble
a697999837a69 23/04/17 Hide Inactive Tabs UI on backgrounding
1f01f135e1550 23/04/17 Dismiss Inactive Tabs UI on initiating New
                       Search
6f64fdf40d396 23/04/14 Share tab creation EG utils
8f7bfc7724f8e 23/04/14 Add test utils for simple dynamic routes with
                       test server
22b502bcf4356 23/04/14 Bring parity to TabSwitcher-creating mediators
e5048c9b07de4 23/04/11 Introduce WebStateTabSwitcherItem
675e907b7c4a1 23/04/08 Make L10nUtils more idiomatic in Swift
36a95355e1948 23/04/06 Update Inactive Tabs UIs when settings change
81df15f3d7096 23/04/05 Improve SwiftUI view by using RTL-compatible
                       symbol
3074ada6670ea 23/04/03 Add user education panel for Inactive Tabs
cc4512d23001d 23/04/03 Simplify Inactive Tabs days threshold flow into
                       UI
d24a17e5fc6b2 23/03/30 Keep the inactive tabs grid scroll position
aa5ab3bf19b71 23/03/30 Add Inactive Tabs preamble with a link to
                       Settings
a10ca3c788a8b 23/03/25 Add a Close All Inactive button
b1219288e8001 23/03/25 Fix typos on "incognito"
97f0052767e76 23/03/24 Remove unused property
32f05a69472e1 23/03/24 Explicitly import the bridging header in
                       inactive_tabs_button_ui_swift
a1c039335f45e 23/03/23 Add context menu to Inactive Tabs
33dcbbbf10b8f 23/03/23 Inject a browser state instead of a browser in
                       TabContextMenuHelper
17dd2a98b8036 23/03/20 Add more comments re: MenuBuilder
3f85d60472a48 23/03/18 Remove code prior to Keyboard Shortcuts Menu
89a7a5236c28c 23/03/17 Remove code prior to Keyboard Shortcuts Menu
ab66e85c5250c 23/03/16 Fix RTL direction of disclosure indicator in
                       Inactive Tabs Button
7f058f8b4e589 23/03/16 Close an inactive tab
e5aa31b666bd2 23/03/15 Disable tab grid manual reordering when sorting
                       by recency
3f2c7137b7607 23/03/14 Display inactive tabs with most recent at the
                       top
5960c496d25d2 23/03/14 Implement Inactive Tabs Button in SwiftUI
3c0182c832ec1 23/03/14 Fix drag&drop in Tab Grid
a0169837147c4 23/03/09 Prevent Drag&Drop in GridViewController when
                       handler is not set
3b834dd5ca90d 23/03/09 Clean up Inactive Tabs mediators
186418e7f0662 23/03/08 Support ESC keyboard shortcut in Tab Grid
6814160f82e58 23/03/01 Add background blur and content inset to
                       Inactive Tabs View Controller
a3383f016287e 23/02/28 Use the real inactive tabs count in Tab Grid
be9d050c6bdbc 23/02/23 Use the inactive tabs browser in the inactive
                       tabs grid
77835118833b1 23/02/22 Add snapshots to inactive tabs
133f036ae6e3b 23/02/21 Add InactiveTabsMediator
e1a57eb07b9cf 23/02/21 Add DCHECK(IsInactiveTabsEnabled()) where
                       warranted
f44aa88afa518 23/02/20 Use weakSelf when preloading snapshots in Tab
                       Grid
f6feb5e8f881a 23/02/20 Let InactiveTabsCoordinator be grid view
                       controller delegate
c7dedc1831366 23/02/16 Add a GridViewController inside
                       InactiveTabsViewController
58f355021996d 23/02/14 Add flag to conditionally the Inactive Tabs
                       count
628db28f4b74f 23/02/13 Add an empty InactiveTabsViewController
3f78f814b1f1f 23/02/13 Move the max count of inactive tabs to a
                       variable
d23842f10f872 23/02/13 Add the Inactive Tabs button in Tab Grid
d9371ec451380 23/02/09 Refactor data source methods with switch cases
875af181be282 23/02/09 Add a proper reuse identifier in
                       GridViewController
dc5278fa3c975 23/02/09 Remove unused variable
e4ffbc33f362b 23/01/30 Remove unused -closeAllConfirmationDisplayed
afa96a368505b 23/01/27 Disable Inactive Tabs on iPad
93e9b50aec30a 23/01/26 Add tab inactivity threshold flag
48a59bf04cea3 23/01/13 Migrate kSecondaryToolbarGuide to
                       LayoutGuideCenter
bb90091024f4a 22/12/14 Migrate kTabGridBottomToolbarGuide to
                       LayoutGuideCenter
b0451250d6588 22/12/10 Make sure to animate the keyboard in tab search
9e9f7d6ae525d 22/12/09 Fix a broken animation with Tab search scrim
92888ddeb41b9 22/11/23 Support ESC in Recent Tabs
0069d6d7b9233 22/11/17 Revert "[ios] Check view in window before
                       becomeFirstResponder"
db75dce87792e 22/11/16 VCs with keyCommands can become first
                       responders
f6b9965bb25bb 22/11/08 Don't show key commands in Recent Tabs
8696d6cf02320 22/11/08 Add missing ⌘N in Tab Grid
2c539d95ad02b 22/11/07 Add missing UMA
9780b822705f7 22/10/26 Remove some key commands when the menu is
                       active
6ea72433f8ba4 22/10/25 Use common key commands in TabGrid

Bug: none
Change-Id: Ibf3ee05cd4f8565b544633352491b56b74a49b66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4728425
Auto-Submit: Louis Romero <lpromero@google.com>
Reviewed-by: Aliona Dangla <alionadangla@chromium.org>
Commit-Queue: Aliona Dangla <alionadangla@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1176504}
3 files changed
tree: 005cfb574d5d071595b72e985ab5913d20edf9b9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.