Google Git
Sign in
chromium / chromium / src / 5dd54ec954730e5508fdf78ed99eec2d2bfb7ec2
commit5dd54ec954730e5508fdf78ed99eec2d2bfb7ec2[log] [tgz]
authorMarc Treib <treib@chromium.org>Thu Dec 08 16:40:32 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Dec 08 16:40:32 2022
tree7cfba3b9d9cfedf3b4c98406a6c30e9ce6d97e9c
parentc49047b5c0631f79126de0c84c55b5e0ef3b7b05 [diff]
History Sync: Plumb syncer::ReportUnrecoverableError into history code

Sync bridges receive a "dump stack callback" on construction, which
they use to report some rare unrecoverable errors.
Before this CL, the History-related bridges (TYPED_URLS and HISTORY)
simply used a null callback, thereby bypassing the error reporting.

This CL hooks up syncer::ReportUnrecoverableError instead, enabling
error reporting. The main change is plumbing in the
version_info::Channel from the history service factory.

Bug: 1318028
Change-Id: I05f408efd25278dcfcfdccb5997934310b843337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4075687
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1080960}
1 file changed
tree: 7cfba3b9d9cfedf3b4c98406a6c30e9ce6d97e9c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.