commit | 5de99f2d63898410388e1c54d18c8184bbc9a6a4 | [log] [tgz] |
---|---|---|
author | Xiaocheng Hu <xiaochengh@chromium.org> | Wed Feb 09 22:27:25 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 09 22:27:25 2022 |
tree | ba185f2be269563e365eaae1416bdee3e3c20fca | |
parent | 0f049ac9f14f33e0950d236ba502438ea984921e [diff] |
Revert "[LayoutNG] Add PropagateChildBreakValues flag to the ConstraintSpace" This reverts commit 9ef53870dd7989885aceb015576bb7e7eb086422. Reason for revert: Tentatively reverted to see if it's the culprit of https://bugs.chromium.org/p/chromium/issues/detail?id=1295835 Original change's description: > [LayoutNG] Add PropagateChildBreakValues flag to the ConstraintSpace > > This CL adds a new flag to the ConstraintSpace to propagate child break > values (initial-break-before and previous-break-after). > > The flag is currently set when setting up the constraint space for > fragmentation. However, it will also be used in future changes outside > of the normal fragmentation pass to determine the initial-break-before > and final-break-after for rows. > > The code that performs child break value propagation in > MovePastBreakpoint() was moved to the builder, and it is run > whenever the new flag is set to true. > > This fixed a bug where we failed to propagate up the break values of > a child if there was no BFC block-offset. The reason was that we > never called BreakBeforeChildIfNeeded() in that case. By moving the > propagation to the builder, instead, we can ensure the break values > are correctly propagated in this case, as well. > > Bug: 829028,1293291 > Change-Id: I2afd288cad99d11a1c414aca5844d7a77afef46f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433832 > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Commit-Queue: Alison Maher <almaher@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#969018} Bug: 829028,1293291,1295835 Change-Id: I41b6c7980bad463f223d05765c24d17af675ac97 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448207 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#969149}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.