Google Git
Sign in
chromium / chromium / src / 5e0a0c6a68a3509b578febde5ec103fa16665fad
commit5e0a0c6a68a3509b578febde5ec103fa16665fad[log] [tgz]
authorJun Choi <hongjunchoi@chromium.org>Wed Nov 14 16:12:18 2018
committerCommit Bot <commit-bot@chromium.org>Wed Nov 14 16:12:18 2018
treef4028ae865397719d1e6fce1cfd33071d6c70536
parent3e34b190866767a53598230f4a2668ec45b1bdfa [diff]
Remove callbacks bound to base::Unretained(this) in FidoBleDevice

Replace callbacks in FidoBleDevice bound to base::Unretained(this) to
callbacks bound to weak pointers. When user navigates away from the site
calling the WebAuthN API while request is being dispatched, callbacks in
FidoBleDevice may be invoked after FidoBleDevice is destroyed. This is
especially the case when the user navigates away during pairing process.
In this case, FidoBleDevice::OnReadControlPointLength() will be called
after FidoBleDevice is destroyed.

Bug: 877344
Change-Id: I14ad94cfc9624c50eeee88feb1a12a6f8488c696
Reviewed-on: https://chromium-review.googlesource.com/c/1335727
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607999}
1 file changed
tree: f4028ae865397719d1e6fce1cfd33071d6c70536
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .