Minor fixes to web_app::GetIconTopLeftColor. This makes sure that we're not leaking `source`, and also adds error handling to make sure we don't end up in undefined behavior territory if the icon for some reason fails to load. This should not help with test flakiness in this area, since in at least all the related errors I've seen we successfully load an icon, the icon just is wrong. It shouldn't hurt either though. Bug: 1355529 Change-Id: Idd70243d52a62aa4e0f3e86c329c8e47da05bf63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3853914 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/main@{#1039307}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.