commit 5e90ab1c854cfd8c57d6ed74e242d88a302c904b
author David Baron <dbaron@chromium.org> Wed Dec 14 22:29:47 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Dec 14 22:29:47 2022
tree b34328a1cc9ff2f99fc099781c071d8d95b45a60
parent cf8ac6cc2894e37a7d0f40568b8e4cfe5f166dbd

Revert "Support logging BFCache reason when Authorization header is on XHR."

This reverts commit e25cfd32faf6ef2fc07506f36ab0c6dcb62fc6a9.

Reason for revert:  This change caused there to be stderr output for some attribution reporting tests that have a filename that is too long, which in turn caused the entire wpt test suite run to fail on Windows because it's trying to archive results for the overly-long filename.

Based on the Linux run, the stderr output in question is:
[4358:4358:1214/140029.821375:ERROR:back_forward_cache_impl.cc(657)] BackForwardCacheImpl::GetFutureBackForwardCacheEligibilityPotential: https://web-platform.test:8444/wpt_internal/attribution-reporting/attributionsrc-request-format.sub.https.html?method=fetch&eligible=event-source&expected-eligible=event-source&expected-support=web : No: BackForwardCache::DisableForRenderFrameHost() was called: 1:0:disabled for web_test not to cache the test page after the test ends.:
[4358:4358:1214/140029.821598:ERROR:back_forward_cache_impl.cc(657)] BackForwardCacheImpl::GetFutureBackForwardCacheEligibilityPotential: https://web-platform.test:8444/wpt_internal/attribution-reporting/attributionsrc-request-format.sub.https.html?method=fetch&eligible=event-source&expected-eligible=event-source&expected-support=web : No: BackForwardCache::DisableForRenderFrameHost() was called: 1:0:disabled for web_test not to cache the test page after the test ends.:

Original change's description:
> Support logging BFCache reason when Authorization header is on XHR.
>
> Previously this only covered fetch. This moves the check into a more
> central location so that it covers XMLHttpRequest too.
>
> Bug: 1382407
> Change-Id: I6aa25fd14fc0afff7592f82df59e883326876905
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4099950
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Reviewed-by: Keishi Hattori <keishi@chromium.org>
> Commit-Queue: Fergal Daly <fergal@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1082937}

Bug: 1382407,1400998
Change-Id: I1389f8b885fc9615e7a4f7e6662d2ee2dd0edbe7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4108392
Owners-Override: David Baron <dbaron@chromium.org>
Auto-Submit: David Baron <dbaron@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1083386}