Google Git
Sign in
chromium / chromium / src / 5ece13ca9e32205d5052fa40a41980673cfd5040
commit5ece13ca9e32205d5052fa40a41980673cfd5040[log] [tgz]
authorBruce Dawson <brucedawson@chromium.org>Thu Feb 29 20:37:34 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 29 20:37:34 2024
treec6f4efdea0716a2e5b43b15d6999f31b168fb61e
parentc075e8bcc481284dfea04c7391d3d3ab80cf10c0 [diff]
Improve intentional-browser-crash identifier

If a user navigates to chrome://inducebrowsercrashforrealz then they
will, not surprisingly, crash the browser process. This has recently
been done a lot when testing the crash system on the ARM64 Windows
version of Chrome.

Unfortunately Google's crash system labels these crashes with
content::HandleDebugURL which makes it not obvious that the crash was
actually requested. And, it means that any actual crash in this function
(unlikely) would be conflated with the intentional crashes.

The fix is easy: move the crash to a separate function and tag it as
NOINLINE. The same logic applies to HangCurrentThread so I tagged it as
NOINLINE as well.

HandleDebugURL has had at least twelve bugs filed against it over the
years. Maybe this will prevent future ones.

to confirm that this change fixes the call stack.

Test: Manually crashed the browser (release build) and used the debugger
Bug: 40839653
Change-Id: Icf7ebf2b91fb4323df1da63fc86289839a03955a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5334277
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1267177}
1 file changed
tree: c6f4efdea0716a2e5b43b15d6999f31b168fb61e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.