| commit | 5ef98f4f86c5dba871a00f357a72b67bcb4bcefb | [log] [tgz] |
|---|---|---|
| author | Egor Pasko <pasko@chromium.org> | Mon Aug 12 17:31:14 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Aug 12 17:31:14 2024 |
| tree | 9f37ece6c435eb9a770248fa4cc3656baba17958 | |
| parent | 479300ca208bc9f8388ed89977e23246b9383fcb [diff] |
check_orderfile: Also check symbols with dot in name It turns out that when verifying symbol order, all symbols with '.' in their name are ignored. This is probably coming from the days when the orderfile was listing the order of _sections_ instead of _symbols_ (as it currently does). A number of sections in the orderfile was in the form of '.text.foo' or '.text.hot.foo' after the 'orderfile patching' step. These days adding those prefixes is not necessary. Regardless of the section the function appears in, its symbol will remain unchanged, and LLD would be able to find this section by the symbol's name. However, with some more aggressive ThinLTO on arm64 a large number of symbols get renamed by appending a unique suffix, like so: ``` foo.llvm.2659584300663683305 ``` Include functions like that in order verification. Bug: 340534475 Change-Id: I3ecf41cb15cfe74560ad4df8689cc6b2332ffbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5783914 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1340471}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.