commit 5f2ea984f2ae5dfcc901b404bc6c75872f572c63
author Devlin Cronin <rdevlin.cronin@chromium.org> Thu Jul 28 02:27:33 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jul 28 02:27:33 2022
tree 631089c78940cc237a493ad7d105acbf09deb391
parent 699bd37e28e20e890538e7ce4cba422d9759789b

[Extensions] Coalesce web request data into a struct

Currently, the ExtensionWebRequestEventRouter stores lots of data
about ongoing network requests in various maps. If we unpack these,
they become:

// ListenerMap
std::map<content::BrowserContext*,
         std::map<std::string,
                  std::vector<std::unique_ptr<EventListener>>>>

// CrossBrowserContextMap
std::map<content::BrowserContext*,
         std::pair<bool, content::BrowserContext*>>;

// ExtraHeadersListenerCountMap
std::map<content::BrowserContext*, int>

All of these are used to store information mapping to a BrowserContext.
We can simplify this significantly by instead having a single struct
that stores per-context data and includes the listener maps, cross-
context information, extra headers listener counts, and incognito state.
This results in both more readable code and reduces the likelihood of
these states getting out-of-sync with one another.

This has two additional benefits:
- This will make tracking and handling service worker listeners
  much easier.
- In a future world where ExtensionWebRequestEventRouter becomes a
  KeyedService (or similar), it is much easier to migrate to the pieces
  we need.

This CL should be pure refactoring and have no behavior change.

Bug: 1024211
Change-Id: I982a4645cc7b06dcc285628ca83227f061137cb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3785797
Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1029054}