commit 5f34e2f7df877381d22ba09e041839927b45880d
author Peter Boström <pbos@chromium.org> Thu Dec 19 01:07:54 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Dec 19 01:07:54 2024
tree fa2542f02ed84e97266516f1b65deac4aecf2973
parent 5b86fcd766843698c954585d83ceb4046375cf2b

Reland "Skip calling __builtin_FUNCTION() for CHECKs"

This reverts commit 325a1a6ae5f15a2c432d668b20d1c77878ff0fd6.

Reason for revert: Orthogonal to failure, rebasing and relanding.

Original change's description:
> Revert "Skip calling __builtin_FUNCTION() for CHECKs"
>
> This reverts commit 58ccc3a8d579cdcf1892052ce3852fd15f713eaa.
>
> Reason for revert: To revert https://chromium-review.googlesource.com/c/chromium/src/+/6095761 (Please see
> crbug.com/384553537 for more details.)
>
> Original change's description:
> > Skip calling __builtin_FUNCTION() for CHECKs
> >
> > base::Location::Current()'s function_name was immediately discarded in
> > all CHECK-failure invocations. This should make call sites cheaper and
> > reduce binary size (fewer function-name strings). No speed savings
> > measured but redundant parameter passing and strings seem unnecessary.
> >
> > Bug: 40241607
> > Change-Id: Ib487cfe2b22575235c0538651fa8f8215d0fb04f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097831
> > Commit-Queue: Peter Boström <pbos@chromium.org>
> > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> > Reviewed-by: Peter Kasting <pkasting@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1397137}
>
> Bug: 384553537, 40241607
> Change-Id: I3a8f75357c333050830c2850c20e98b82e48a19f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6099775
> Commit-Queue: Taiyo Mizuhashi <taiyo@chromium.org>
> Owners-Override: Taiyo Mizuhashi <taiyo@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1397790}

Bug: 384553537, 40241607
Change-Id: I03ce8f94881eee3089465788d0eb00793a60f775
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108296
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1398342}