commit 5f49142eb086b425f52bb63592ea0a1540e5b2ac
author Tommy Steimel <steimel@chromium.org> Tue Feb 21 12:51:37 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Feb 21 12:51:37 2023
tree 4f5c9183a87d0852b41187e9204ba4a5f33e7c5e
parent 534b86e4eadb0f265696618036a2dff0ecf917f3

PiP 2.0: Ensure subsequent about:blank loads close the PiP window

Document PiP windows should always close if navigated from the initial
about:blank document. However, the logic allowed for about:blank
navigations to allow the initial navigation to succeed. This opens up a
couple of issues:

1) Refreshing the PiP document breaks but does not close the document

2) Setting the location of the PiP window to about:blank in JS would
disconnect the PiP document from the original window and render it
unusable.

This CL changes that logic to only allow the initial synchronous about:blank navigation to succeed. However, this is insufficient for the
second issue, since there was a race where if the navigation succeeded
before the page closed, then the RenderFrameHostImpl would cancel the
closing action. In order to fix this (and other issues with navigations
canceling the close action), this CL also makes close requests from the
browser side always close the page regardless of navigations.

Bug: 1413919, 1406023, 1414124, 1414975
Change-Id: Ib52875be2ad107ce3f33e2682b0b87f2c7bc6cbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4242019
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1107695}