Rework "frozen size" handling in RemoteFrameView

In preparation for fixing crbug.com/1128016, rework how the "frozen
size" of a <fencedframe> (for MPArch) is handled by adding a new
RemoteFrameView::UpdateFrozenSize() function that is called every time
the frame rect is updated. This function checks if the associated
LayoutObject has a frozen size, and if so updates the |frozen_size_|
member and marks the view as needing rect propagation. Other code is
changed to read from the member variable rather than fetching the value
themselves.

This helps (will help) for the 0x0 case where the (frozen) frame size
wouldn't otherwise have been propagated to the remote frame, because
the change to the frame size wasn't noticed at the right time. Since a
frame (view) starts out as 0x0, a "new" size of 0x0 will not trigger a
frame-rects-changed signal, and detecting in
RemoteFrameView::UpdateCompositingRect is too late, since then we don't
know when the frame-rect will be propagated next.

Bug: 1128016, 1303855
Change-Id: Ib9d9330990b8d643910755478da90752cf828a47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3975137
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1065616}
2 files changed
tree: db173819f5d4fa38c9683c362420477fca621c6d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.