commit | 5f8934e7418b974f3808e24a34ba1f289d83c365 | [log] [tgz] |
---|---|---|
author | Fredrik Söderquist <fs@opera.com> | Mon Oct 31 19:20:02 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Oct 31 19:20:02 2022 |
tree | db173819f5d4fa38c9683c362420477fca621c6d | |
parent | c5615775c10428fd56788a97ab7d30f756bb6503 [diff] |
Rework "frozen size" handling in RemoteFrameView In preparation for fixing crbug.com/1128016, rework how the "frozen size" of a <fencedframe> (for MPArch) is handled by adding a new RemoteFrameView::UpdateFrozenSize() function that is called every time the frame rect is updated. This function checks if the associated LayoutObject has a frozen size, and if so updates the |frozen_size_| member and marks the view as needing rect propagation. Other code is changed to read from the member variable rather than fetching the value themselves. This helps (will help) for the 0x0 case where the (frozen) frame size wouldn't otherwise have been propagated to the remote frame, because the change to the frame size wasn't noticed at the right time. Since a frame (view) starts out as 0x0, a "new" size of 0x0 will not trigger a frame-rects-changed signal, and detecting in RemoteFrameView::UpdateCompositingRect is too late, since then we don't know when the frame-rect will be propagated next. Bug: 1128016, 1303855 Change-Id: Ib9d9330990b8d643910755478da90752cf828a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3975137 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1065616}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.