Google Git
Sign in
chromium / chromium / src / 6052ee15112d47987fba9d600cda3358aa4d03cf
commit6052ee15112d47987fba9d600cda3358aa4d03cf[log] [tgz]
authorMorten Stenshorne <mstensho@opera.com>Wed Oct 11 21:39:24 2017
committerCommit Bot <commit-bot@chromium.org>Wed Oct 11 21:39:24 2017
tree007583565df3323682e143e02bcde4145626f50a
parentf3c5a28fc399dc6212f3604ef602d1748ce6aeca [diff]
[LayoutNG] Enable inline children special code for flow threads.

PlaceChildrenInLayoutBox() has special code for inline child fragments, to
basically skip them, unless we find floats. This wasn't executed for multicol.
This caused DCHECK failures and incorrect layout.

A few new tests now pass. One regresses, but that's because the test expected a
float to be at block offset 0, which it happened to be, since we didn't even
attempt to place it. Now we place it. We place it incorrectly, but at least we
place it. :)

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ifee30438885c267f9d6c271a0db2f5c0f191fad6
Reviewed-on: https://chromium-review.googlesource.com/713858
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#508126}
3 files changed
tree: 007583565df3323682e143e02bcde4145626f50a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .