| commit | 60987aa224f369fc0ea38c56e498389440921356 | [log] [tgz] |
|---|---|---|
| author | Hongchan Choi <hongchan@chromium.org> | Tue Feb 09 17:40:12 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Feb 09 17:40:12 2021 |
| tree | 674b3e63e142a3b72dcd6fbf124a8ce56d9a3c22 | |
| parent | f190c52ba161caccca1a6a599a1df7cb5d1aba24 [diff] |
Prevent accessing shared buffers from audio rendering thread The shared buffer in ScriptProcessorNode can be accessed by the audio rendering thread when it is held by the main thread. The solution suggested here is simply to expand the scope of the mutex to minimize the code change. This is a deprecated feature in Web Audio, so making significant changes is not sensible. By locking the entire scope of Process() call, this area would be immune to the similar problems in the future. Bug: 1174582 Test: The repro case doesn't crash on ASAN. Change-Id: I2b292f94be65e6ec26c6eb0e0ed32b3fb2d88466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2681193 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#852240}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.