commit | 610c2ef0ab0c47205c2d1fea248ce43d0914e299 | [log] [tgz] |
---|---|---|
author | manukh <manukh@chromium.org> | Tue Aug 12 21:39:16 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Aug 12 21:39:16 2025 |
tree | ad2af885fbcd454d16c4de2e4caf7f96ef959aee | |
parent | bcee7e637770f9e8ee500d72ef1ba9fd7f431022 [diff] |
[omnibox][ai-mode] Write/read GWS request to prefs The GWS server may be down. Or may be slow in responding. Or chrome may need to access eligibility on startup before the 1st response has returned and parsed. To handle all these cases, the eligibility service will write the GWS response to prefs when it's successfully parsed. Error responses (empty or failed to parse) will not overwrite the pref. Pref will be read on service construction and used until a new successful GWS response overwrites it. Pref is stored as proto string. E.g. `"\b\u0001"`. I did not find any other examples of proto or binary encoded strings stored in prefs. But mapping the proto to a JSON dictionary seemed wasteful. Also considered writing to a standalone file, like bookmarks do, instead of to pref. It was equally simple to implement. But pref contains a lot of catch-all data, and we don't have many examples of small pieces of data getting their own dedicated files. So seemed like the precedence leans towards stuffing this small piece of data into prefs. Pref is named `aim_eligibility_service.aim_eligibility_response`. Bug: 436899694, 436225340 Change-Id: Ia4a59d93df5220956b11c4ff701ff2dab46f9672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6833343 Reviewed-by: Ananya Seelam <ananyaseelam@google.com> Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1500431}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.