commit | 614a564a9ca2304c350bd493aff7cc2ebaf03666 | [log] [tgz] |
---|---|---|
author | Lijin Shen <lazzzis@google.com> | Tue Jul 12 18:32:31 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jul 12 18:32:31 2022 |
tree | 289ea62d01c91cfec793064818b018867529e4e0 | |
parent | ed63ab1643f5a566fc5e1df1ad151c4afbe4dca4 [diff] |
[M103][Messages][SaveCard] Fix metrics recording error 1. for fix name dialogs, "Dismissed" is never called and is counted as "InteractedAndIgnored", because CardNameFixFlowControllerImpl::OnDismissed is never called by CardNameFixFlowViewAndroid when dialog is dismissed by user. In uma dashboard, there is almost no record of Autofill.CardholderNameFixFlowPrompt.Events#Dismissed. 2. for message dialogs, "Dismissed" is sometimes counted as "InteractedAndIgnored" by mistake, because kDenied is not recorded when the dialog is dismissed by user. (cherry picked from commit 2af4a7307b9e885f24bb678c477363194ea76dce) Bug: 1190531 Change-Id: If57410bc52caaa0325f38d49898690f4e1b6eb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688046 Reviewed-by: Jared Saul <jsaul@google.com> Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by: Aishwarya Rajesh <aishwaryarj@google.com> Reviewed-by: Siddharth Shah <siashah@chromium.org> Reviewed-by: Elizabeth Popova <lizapopova@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1013079} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3755629 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/branch-heads/5060@{#1206} Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.