Google Git
Sign in
chromium / chromium / src / c740c937aad5b3c32bc16c8aaea8ac9eb7ae6f5c
commitc740c937aad5b3c32bc16c8aaea8ac9eb7ae6f5c[log] [tgz]
authorDivyansh Mangal <dmangal@microsoft.com>Tue Jul 09 10:14:07 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jul 09 10:14:07 2024
tree0ee1f359af657033cd19decf95b00d6633ea9efd
parent1851aa426bf4ba5c93bf46174e994bf5da8ac775 [diff]
[views-ax] Migrating kExpanded and kCollapsed attribute to new system for popup view views

This CL migrates the kExpanded and kCollapsed state in
popup_view_views.cc whenever its value should change,
rather than querying the value and computing it only when needed.

This CL also contains unit tests to check whether the correct accessible
state is getting set whenever the popup view shows or hide.
Note: Whenever the popup view is hidden the underlying widget itself
gets hidden as such the GetAccessibleNodeData was not setting the correct state in the data variable.
This CL also includes the correct update of the collapsed state when the underlying widget is closed.

This CL is part of the ViewsAX project:
https://docs.google.com/document/d/1Ku7HOyDsiZem1yaV6ccZ-tz3lO2XR2NEcm8HjR6d-VY/edit#heading=h.ke1u3utej413

Bug: 325137417
Change-Id: I51fdceab90ef4ab3d29e5edcf3c527e1955d9350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648620
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Divyansh Mangal <dmangal@microsoft.com>
Reviewed-by: Javier Contreras <javiercon@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1324771}
4 files changed
tree: 0ee1f359af657033cd19decf95b00d6633ea9efd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.