Google Git
Sign in
chromium / chromium / src / 61dfcce645ff01e60ad026e579774e3b5467a30b
commit61dfcce645ff01e60ad026e579774e3b5467a30b[log] [tgz]
authorArmando Miraglia <armax@chromium.org>Thu Jan 10 08:58:04 2019
committerCommit Bot <commit-bot@chromium.org>Thu Jan 10 08:58:04 2019
tree38053d9ddba0ea0f4baaa958b7c26be73e3851d5
parent937f6250959d6b976b2a52a3d8b5360af1c80957 [diff]
[getUserMedia] Remove default value update for auto mirroring based on ec.

The logic that was upstream before the main refactoring of the
constraints made so that the default value of autoGainControl would not be
effected by echoCancellation. This CL fixes the current implementation
to reflect such behavior.

Qualitatively, however, this should not have an impact because (a) this
would only effect the default value, and most importantly (b) the
assignment was &= rather than a plain assignment.

There are already tests in place to prevent regressions in this area.

BUG=731170

Change-Id: Icf5a161654b57c70d66cbea7ab209156204a4838
Reviewed-on: https://chromium-review.googlesource.com/c/1402801
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621511}
1 file changed
tree: 38053d9ddba0ea0f4baaa958b7c26be73e3851d5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .