Ignore disconnect signals when a QUIC connection migration is happening on the default network

Suppose that both wifi and mobile networks are active and the default
network is wifi. When wifi becomes unavailable, there could be two
signals from NetworkChangeNotifier via NetworkObserver to trigger
a QUIC connection migration:
- OnNetworkDisconnected() to signal wifi becomes inactive
- OnNetworkMadeDefault() to signal mobile becomes the default network

The former doesn't require proving, but the latter requires proving.

The order of these signals is not guaranteed. Before this CL,
QuicChromiumClientSession didn't handle the case where
OnNetworkMadeDefault() comes first and the OnNetworkDisconnected()
comes next. There was no valid connection IDs until proving finished,
but QuicChromiumClientSession::OnNetworkDisconnectedV2() tried to
migrate immediately, resulting in a migration failure.

To avoid the problem, ignore disconnect signals when a migration is
happening on the default network.

The existing QuicConnectionMigrationTest.Basic test will cover this
change once it starts running on bots.

Bug: 1509458
Change-Id: I9b348ad82ef004800356f5b63c1f702c1d09ccca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5138419
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Stefano Duo <stefanoduo@google.com>
Cr-Commit-Position: refs/heads/main@{#1242768}
3 files changed
tree: 8ca3d3376b6b7b730e6c929b684ac0672efedd83
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.