Google Git
Sign in
chromium / chromium / src / 622af2ab121fa62e79c6549e1e456f31fcf50c47
commit622af2ab121fa62e79c6549e1e456f31fcf50c47[log] [tgz]
authorXianzhu Wang <wangxianzhu@chromium.org>Tue Dec 17 01:20:24 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Dec 17 01:20:24 2024
treebeb5f4b94f4fe34b8d470436a403d11cfec63bab
parent2811cf9bf3fa12ec3b5a9f1f16e6b539902e6055 [diff]
Refactor PaintOp classes to prevent (and fix) wrong usages

PaintOp is not runtime polymorphic by itself, but implements runtime
polymorphism with manual subclass dispatching. Most of the non-virtual
functions defined in PaintOp are supposed to be called from leaf
subclasses only. Calling them from an object with compile-time
PaintOp type may get wrong results.

This CL makes these functions protected in PaintOp[WithFlags] to
prevent them from being called from outside. They are made public
in PaintOp[WithFlags]InternalBase classes which are the parent
class of all real paint op classes.

Two problems (for tracing and metrics, not affecting rendering)
are fixed:
- DisplayItemList::Raster() incorrectly called

  PaintOp::AdditionalOpCount() for tracing.
- DisplayItemList:AreaOfDrawText() missed some ops (e.g.
  DrawScrollingContentsOp) containing draw text ops partly due to
  lack of PaintOp::OpHasDrawTextOps() (added and used in this CL).

Change-Id: Iaf638cfd3286c4df0ac82b75ccc28524188c1ead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072123
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397094}
3 files changed
tree: beb5f4b94f4fe34b8d470436a403d11cfec63bab
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.