Add checked casts for the length of a base::StringPiece.

Since not all consumers of base::StringPiece use a full warning
configuration, this prevents accidentally passing a signed value
into the length, which could result in a buffer overflow happening.

A test is added to verify this new behavior.

A few small companion changes were needed to get green bots:

1. websocket_frame.h was using the 'enum hack' for constants, these
were changed to real constants, otherwise base::CheckedNumeric
would fail with static assert in tests as an enum is not arithmetic.
2. CheckedNumeric constructor could incorrectly match non-numeric
types. This caused an incorrect overloaded function match in the
suggestion parser unittest [1]. The CheckedNumeric constructor was
therefore disabled for non-arithmetic types.

[1] - https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1201914/overview

BUG=1385166

Change-Id: Ic01aec5e08fc4121373f5429593a340a0497c7d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4021423
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1073064}
4 files changed
tree: 2214aacf6fb1e34fd0c2c3f484f7338ff6424dbb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.