commit | e5e713ea03d4573796b4f62347935e76903142fb | [log] [tgz] |
---|---|---|
author | Antonio Gomes <tonikitoo@igalia.com> | Fri Mar 15 05:56:07 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Mar 15 05:56:07 2019 |
tree | 1305b7e12d1304cd66458aeac0969f2b9e1b3be7 | |
parent | 1108c4224984e1e247ec3fd2ee5b43f1f04f1f88 [diff] |
Invoke FileSystemCallbacks's success/error closures directly Previously, the success and error callbacks in the various classes in [1] were either invoked immediately or scheduled to run depending on the execution context's task runner. Lately, according to offline conversations with mek@chromium.org, it is possible to get rid of the scheduling logic altogether because an earlier, change made it so that things like FilesystmeDispatcher::DidReadMetadata already run on a per-execution context task runner, and presumably they would already be scheduled properly. This CL implements that idea, as part of the effort to clean FileSystemCallbacks's implementation. It also greatly simplifies FileSystemCallbacksBase, which can be eliminated in a follow up CL with minimal effort. [1] //third_party/blink/renderer/modules/filesystem/file_system_callbacks.h R=mek@chromium.org CC=blink-reviews-vendor@chromium.org, dgozman@chromium.org BUG=933878 Change-Id: Ib446249bab8ac1c9d9f2e4d11340d258cbac1751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525101 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#641097}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .