commit 625930782918af8cbb37c068e6fc24c214ab006f
author Arthur Milchior <arthurmilchior@chromium.org> Tue Jan 07 11:07:04 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jan 07 11:07:04 2025
tree 4bac9f513d5ac19a2ea6aee43c5a1563811b7c6e
parent 94355ac2d2aaff074fcf701c77c578848ca3e64f

[iOS]Introduce GREYAssertErrorNil

Usually, `error.description` contains useful information that help to
debug code failure. This information is not accessible in the log of
the failing message. Instead, a generic string is provided which
provides less information.

This CL add an helper function GREYAssertErrorNil that assert
that the error is nil. If the error is not nil, it prents the
description, followed potentially by the error message.

I replaced a few use where it’s easy to see that this replacement will
lead to better failure message. In particular over histogram related
methods, as the issue I was originally debugging was over
histogram. There remains hundreds of `GREYAssertNil` on error which
may be worth replacing eventually.

Ideally, I’d have preferred to name it `GREYAssertNil` and overload
this function. But as this is defined as a macro, this is not
possible.

Ideally, the message should be a string with format, and accepting a
variable number of parameter. This does not seems something we
currently do in Chrome and I don’t think it’s worth adding it.

Bug: None
Change-Id: I910a94b44cb96ec3f323e1efbe65fadc02a293e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6149288
Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1402869}