Privacy Review: Add a new PrivacyReview feature flag
Bug: 1215630
Change-Id: I3beb7680b97554796babb97e588ff350ad0fe2be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2933343
Reviewed-by: Rainhard <rainhard@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rainhard <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#890172}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 110308f..d481fef 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -7218,6 +7218,10 @@
FEATURE_VALUE_TYPE(::features::kFocusFollowsCursor)},
#endif // BUILDFLAG(IS_CHROMEOS_ASH)
+ {"privacy-review", flag_descriptions::kPrivacyReviewName,
+ flag_descriptions::kPrivacyReviewDescription, kOsDesktop,
+ FEATURE_VALUE_TYPE(features::kPrivacyReview)},
+
// NOTE: Adding a new flag requires adding a corresponding entry to enum
// "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
// Histograms" in tools/metrics/histograms/README.md (run the
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
index ad148e95..f96ea00 100644
--- a/chrome/browser/flag-metadata.json
+++ b/chrome/browser/flag-metadata.json
@@ -4255,6 +4255,15 @@
"expiry_milestone": 94
},
{
+ "name": "privacy-review",
+ "owners": [
+ "rainhard",
+ "andzaytsev",
+ "msramek",
+ "chrome-friendly-settings@google.com"],
+ "expiry_milestone": 100
+ },
+ {
"name": "privacy-sandbox-settings",
"owners": [
"harrisonsean",
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
index 383126b..f0cf6cba 100644
--- a/chrome/browser/flag_descriptions.cc
+++ b/chrome/browser/flag_descriptions.cc
@@ -1995,6 +1995,11 @@
const char kPrivacyAdvisorDescription[] =
"Provides contextual entry points for adjusting privacy settings";
+const char kPrivacyReviewName[] = "Privacy Review";
+const char kPrivacyReviewDescription[] =
+ "Shows a new subpage in Settings that helps the user to review various "
+ "privacy settings.";
+
const char kPrivacySandboxSettingsName[] = "Privacy Sandbox Settings";
const char kPrivacySandboxSettingsDescription[] =
"Enables privacy sandbox settings. Requires at least one of the Privacy "
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
index b3b4f7b7..60ff8b3 100644
--- a/chrome/browser/flag_descriptions.h
+++ b/chrome/browser/flag_descriptions.h
@@ -1145,6 +1145,9 @@
extern const char kPrivacyAdvisorName[];
extern const char kPrivacyAdvisorDescription[];
+extern const char kPrivacyReviewName[];
+extern const char kPrivacyReviewDescription[];
+
extern const char kPrivacySandboxSettingsName[];
extern const char kPrivacySandboxSettingsDescription[];
diff --git a/chrome/browser/ui/webui/settings/settings_ui.cc b/chrome/browser/ui/webui/settings/settings_ui.cc
index 8980dc9d..d6e0a627 100644
--- a/chrome/browser/ui/webui/settings/settings_ui.cc
+++ b/chrome/browser/ui/webui/settings/settings_ui.cc
@@ -330,6 +330,10 @@
"safetyCheckWeakPasswordsEnabled",
base::FeatureList::IsEnabled(features::kSafetyCheckWeakPasswords));
+ html_source->AddBoolean(
+ "privacyReviewEnabled",
+ base::FeatureList::IsEnabled(features::kPrivacyReview));
+
AddSettingsPageUIHandler(std::make_unique<AboutHandler>(profile));
AddSettingsPageUIHandler(std::make_unique<ResetSettingsHandler>(profile));
diff --git a/chrome/common/chrome_features.cc b/chrome/common/chrome_features.cc
index a1ee603b..4e80001 100644
--- a/chrome/common/chrome_features.cc
+++ b/chrome/common/chrome_features.cc
@@ -776,6 +776,9 @@
const base::Feature kPrivacyAdvisor{"PrivacyAdvisor",
base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kPrivacyReview{"PrivacyReview",
+ base::FEATURE_DISABLED_BY_DEFAULT};
+
// Enables the privacy sandbox settings page.
const base::Feature kPrivacySandboxSettings{"PrivacySandboxSettings",
base::FEATURE_ENABLED_BY_DEFAULT};
diff --git a/chrome/common/chrome_features.h b/chrome/common/chrome_features.h
index 8c76f57..221d064 100644
--- a/chrome/common/chrome_features.h
+++ b/chrome/common/chrome_features.h
@@ -520,6 +520,9 @@
extern const base::Feature kPrivacyAdvisor;
COMPONENT_EXPORT(CHROME_FEATURES)
+extern const base::Feature kPrivacyReview;
+
+COMPONENT_EXPORT(CHROME_FEATURES)
extern const base::Feature kPushMessagingBackgroundMode;
#if BUILDFLAG(IS_CHROMEOS_ASH)
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index f402e8f..63824f6e 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -47830,6 +47830,7 @@
<int value="331770879" label="CrostiniAppSearch:disabled"/>
<int value="332391072" label="cs-contextual-cards-bar-integration"/>
<int value="332960119" label="PdfXfaSupport:disabled"/>
+ <int value="333019109" label="PrivacyReview:enabled"/>
<int value="334802038" label="OfflinePreviews:disabled"/>
<int value="335976733" label="NotificationStackingBarRedesign:enabled"/>
<int value="336429189" label="DisallowUnsafeHttpDownloads:disabled"/>
@@ -49858,6 +49859,7 @@
<int value="2051403297" label="ShowBluetoothDeviceBattery:disabled"/>
<int value="2051886966" label="PwaInstallUseBottomSheet:enabled"/>
<int value="2052194225" label="ChromeOSSharingHub:disabled"/>
+ <int value="2055386526" label="PrivacyReview:disabled"/>
<int value="2056572020" label="EnableUsernameCorrection:disabled"/>
<int value="2058148069" label="UseMessagesStagingUrl:enabled"/>
<int value="2058283872" label="CCTModuleCache:disabled"/>
