commit 62dd13a07451dbc8eb294d325bb6aa3bdbe84c2c
author Roland Bock <rbock@google.com> Thu Aug 11 09:52:58 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Aug 11 09:52:58 2022
tree fde711d3425e64be6ca68e67bbfc6482de43c53c
parent 74e82520ded4c6c3e0df7990d0fa4b7e5d9465be

Refactor AccuracyService to use PrefService::GetValue*

This is part of a larger migration effort based on
go/trust-your-prefs.

Bug: 1342019 1341998
Test: Existing unit tests
Change-Id: I887c40f998a5d497899d397e2cb586a045989122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810616
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Roland Bock <rbock@google.com>
Cr-Commit-Position: refs/heads/main@{#1033909}

components/accuracy_tips/accuracy_service.cc

diff --git a/components/accuracy_tips/accuracy_service.cc b/components/accuracy_tips/accuracy_service.cc
index 9d3a2a8..daab3b3 100644
--- a/components/accuracy_tips/accuracy_service.cc
+++ b/components/accuracy_tips/accuracy_service.cc
@@ -111,11 +111,11 @@
                                           AccuracyCheckCallback callback) {
   DCHECK(ui_task_runner_->RunsTasksInCurrentSequence());
 
-  const base::Value* last_interactions =
-      pref_service_->Get(GetPreviousInteractionsPrefName(disable_ui_));
+  const base::Value::List& last_interactions =
+      pref_service_->GetValueList(GetPreviousInteractionsPrefName(disable_ui_));
   const base::Value opt_out_value(
       static_cast<int>(AccuracyTipInteraction::kOptOut));
-  if (base::Contains(last_interactions->GetListDeprecated(), opt_out_value)) {
+  if (base::Contains(last_interactions, opt_out_value)) {
     return std::move(callback).Run(AccuracyTipStatus::kOptOut);
   }
 
@@ -162,8 +162,7 @@
   }
 
   bool show_opt_out =
-      pref_service_->GetList(GetPreviousInteractionsPrefName(disable_ui_))
-          ->GetListDeprecated()
+      pref_service_->GetValueList(GetPreviousInteractionsPrefName(disable_ui_))
           .size() >= static_cast<size_t>(features::kNumIgnorePrompts.Get());
 
   url_for_last_shown_tip_ = web_contents->GetLastCommittedURL();
@@ -182,10 +181,9 @@
 
 void AccuracyService::MaybeShowSurvey() {
   if (CanShowSurvey()) {
-    auto* interactions_list =
-        pref_service_->GetList(GetPreviousInteractionsPrefName(disable_ui_));
-    const int last_interaction =
-        interactions_list->GetListDeprecated().back().GetInt();
+    const auto& interactions_list = pref_service_->GetValueList(
+        GetPreviousInteractionsPrefName(disable_ui_));
+    const int last_interaction = interactions_list.back().GetInt();
     const bool ukm_enabled = pref_service_->GetBoolean(
         unified_consent::prefs::kUrlKeyedAnonymizedDataCollectionEnabled);
     std::string url_parameter_for_hats =
@@ -289,8 +287,7 @@
     return false;
 
   int interactions_count =
-      pref_service_->GetList(GetPreviousInteractionsPrefName(disable_ui_))
-          ->GetListDeprecated()
+      pref_service_->GetValueList(GetPreviousInteractionsPrefName(disable_ui_))
           .size();
   return interactions_count >= features::kMinPromptCountRequiredForSurvey.Get();
 }