commit | 6336939fdbe1a5a7906bcb9495bd805b6ac52a55 | [log] [tgz] |
---|---|---|
author | Di Zhang <dizhangg@chromium.org> | Fri Nov 08 22:41:37 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Nov 08 22:41:37 2024 |
tree | 9c8ef36a8276ae6d136aa077bfbbfb8fb5e157b3 | |
parent | e2b9916925bf96d864cd5d64d0e9e96c40342763 [diff] |
Revert "[PDF Ink Signatures] Set save request type to annotation after edit" This reverts commit 2beca8ed201ab442ccb93f431ece2aec95c87419. Reason for revert: This CL is causing tree failure because of the revert of CL which depends on it: https://chromium-review.googlesource.com/c/chromium/src/+/6006316 Example: https://ci.chromium.org/ui/p/chromium/builders/ci/Win%20Builder/221523/overview Original change's description: > [PDF Ink Signatures] Set save request type to annotation after edit > > There are two ways to save a PDF in the PDF viewer: using the save > button in the toolbar, or using a save browser command. > > For the toolbar button, set the save request type to ANNOTATION only > if there are existing Ink2 edits, rather than always after the user > enters annotation mode. This matches the behavior of CrOS Gallery more > closely. > > For the save browser command, do the same by informing the browser > that the plugin will handle the save after drawing a stroke. Note that > in the edge case where the user undos all strokes, then the plugin will > have the browser handle the save instead. > > Low-Coverage-Reason: COVERAGE_UNDERREPORTED This CL adds tests that > cover new code. > > Bug: 353904284, 377488931 > Change-Id: Iad31cd4907456de1acfb2e35a4fdda343d34981f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6003789 > Commit-Queue: Andy Phan <andyphan@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1380605} Bug: 353904284, 377488931 Change-Id: Ieb1aecea8bba5f5f7d9c3ab209e8b374f2320e22 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6006043 Reviewed-by: Di Zhang <dizhangg@chromium.org> Owners-Override: Di Zhang <dizhangg@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Di Zhang <dizhangg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380659}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.