Google Git
Sign in
chromium / chromium / src / 6387bfd109d0b31de37d40b0318dd0b680906a04
commit6387bfd109d0b31de37d40b0318dd0b680906a04[log] [tgz]
authorJeroen Dhollander <jeroendh@google.com>Wed Dec 16 00:59:49 2020
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Dec 16 00:59:49 2020
tree5d0ebd453d025f88b4e7167bddd8f26064c5b4bf
parent297828daa13982a9eb42fe528de52211cf159c2a [diff]
Allow fake instances of LibassistantService during unittests

All access to the Libassistant classes is being moved inside
the |LibassistantService| mojom classes, so we need to update
the unittests to fake the |LibassistantService| class, instead
of the Libassistant classes.

This CL introduces a |LibassistantServiceHost| which launches/stops
the Mojom service. This CL also introduces fake objects, and updates
the |AssistantManagerServiceImpl| unittests to use these fakes.

Bug: b/171748795
Change-Id: I4742f0c28050f0bce5c11a4d946ec35b3aab449d
Tests: chromeos_unittests --gtest_filter="Assistant*"
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569920
Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837368}
15 files changed
tree: 5d0ebd453d025f88b4e7167bddd8f26064c5b4bf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.