Fix null reference in PaymentDetails validation This fixes UBSan errors like the following: https://luci-milo.appspot.com/ui/inv/build-8763888193215235281/test-results?q=PaymentRequestUpdateWithTest.UpdateWithModifiers&sortby=&groupby= All the validation methods took a const PaymentItem& total parameter and did nothing with it. But as references cannot be null, the call sites called it with *details.total, which is undefined if the pointer is null. Looking at the history, the bug was introduced in https://crrev.com/c/643768. In the old version of the file, the parameter was const payments::mojom::PaymentItemPtr& total, which *can* be null since it's a reference to a smart pointer. In the conversion, this was mistranslated to a non-nullable type: https://chromium-review.googlesource.com/c/chromium/src/+/643768/12/components/payments/content/payment_details_validation.cc https://chromium-review.googlesource.com/c/chromium/src/+/643768/12/components/payments/core/payment_details_validation.cc We just didn't notice because the parameter was unused. The last time the parameter was used was just before this CL: https://codereview.chromium.org/2852363002 Bug: 1394755 Change-Id: I4b983f4ef2d7e04a1d0eb257dfd82994c95fed50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046277 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1227410}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.