commit 641018551819bfb1b1c5e0c5e1890c5906b11e83
author Cheick Cisse <cheickcisse@google.com> Wed Jun 12 21:41:48 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jun 12 21:41:48 2024
tree df0de99a64144243c45c78a50501ed209a4aff98
parent 6c54152c168d416d56070f5f7a5a740dd20b00aa

[PriceInsights][iOS] Polish the y Axis

This CL:
- Extends the bottom AxisTick to covert the longest yAxis label.
- Adds a color to the grid line and ticks.
- Sets the number of ticks to 3.

Screenshot: https://screenshot.googleplex.com/A8Ks3pmp2VbChiv.png

Bug: b/346813191
Change-Id: Iea90a222f55470666b2b93b70ee3d64412402dc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5627572
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Cheick Cisse <cheickcisse@google.com>
Cr-Commit-Position: refs/heads/main@{#1314267}

ios/chrome/browser/price_insights/ui/price_history.swift

diff --git a/ios/chrome/browser/price_insights/ui/price_history.swift b/ios/chrome/browser/price_insights/ui/price_history.swift
index 6ef12e2..e8565eb 100644
--- a/ios/chrome/browser/price_insights/ui/price_history.swift
+++ b/ios/chrome/browser/price_insights/ui/price_history.swift
@@ -105,8 +105,11 @@
   /// Color representing solid white.
   static let solidWhite = UIColor(named: kSolidWhiteColor) ?? .white
 
+  /// Color representing grey 200.
+  static let grey200 = UIColor(named: kGrey200Color) ?? .gray
+
   /// Number of ticks on the Y-axis.
-  static let tickCountY = 4
+  static let tickCountY = 3
 
   /// The selected date on the graph.
   @State private var selectedDate: Date?
@@ -182,14 +185,16 @@
       AxisMarks(position: .leading, values: axisTicksY) { price in
         if let price = price.as(Double.self) {
           if price == axisTicksY.first {
-            AxisTick()
+            AxisTick(length: .longestLabel, stroke: StrokeStyle(lineWidth: 1))
+              .foregroundStyle(Color(uiColor: Self.grey200))
           } else {
             AxisValueLabel(
               format: .currency(code: currency).precision(.fractionLength(0)))
             AxisTick(stroke: StrokeStyle(lineWidth: 0))
           }
         }
-        AxisGridLine()
+        AxisGridLine(stroke: StrokeStyle(lineWidth: 1))
+          .foregroundStyle(Color(uiColor: Self.grey200))
       }
     }
     .chartXScale(domain: axisXRange)