Google Git
Sign in
chromium / chromium / src / 644a01d38fa87f6add2186b951c5c9b4e57d2fdf
commit644a01d38fa87f6add2186b951c5c9b4e57d2fdf[log] [tgz]
authorByungwoo Lee <blee@igalia.com>Wed Jan 17 08:48:03 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 17 08:48:03 2024
treec512b8102bc55e6ce65ff25524c2c7ad0b35286a
parent7b34cef5621acb863d3fdac0dd2276824bc75444 [diff]
Fix :has() invalidation error with nesting parent containing hover

Sets ContainsPseudoInsideHasPseudoClass flag of a :has() selector if its
argument contains nesting parent.

Currently, the CSSSelectorParser doesn't set the above flag if the :has()
selector's argument has a nesting parent selector and the nesting parent
contains a pseudo selector.

Due to this, even if the pseudo state in the nesting parent is changed,
StyleEngine skips :has() invalidation for the pseudo state change because
the :has() anchor element doesn't have AffectedByPseudoInHas flag set.

To fix this, CSSSelectorParser sets ContainsPseudoInsideHasPseudoClass
flag if the :has() selector contains a nesting parent selector in its
argument selector.

Bug: 1517866
Change-Id: I41b6f69a83db41a4e519490018bfb214a724f807
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5203146
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Byungwoo Lee <blee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1248019}
3 files changed
tree: c512b8102bc55e6ce65ff25524c2c7ad0b35286a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.