commit 6452455b6e13841158c07297559d2514fe6c4c40
author Christoph Schwering <schwering@google.com> Sat Dec 07 02:11:01 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Dec 07 02:11:01 2024
tree 569520cfeb582fdbd6d3565825cf8dc17ef628ff
parent a96de80634712966ede863b0b17562690b5fcf19

Reland "[Autofill] Send votes on driver state change"

This is a reland of crrev.com/c/6061418.

Original change's description:
> [Autofill] Send votes on driver state change
>
> This CL emits votes cast by a BAM when the BAM's driver's LifecycleState
> changes. There are three reasons for this change.
>
> Firstly, the CL ensures that destroying or resetting one BAM does not
> flush the votes of another BAM. This used to be guaranteed, but we lost
> the guarantee by moving VotesUploader to AutofillClient in the dependent
> CL crrev.com/c/6049265.
>
> Secondly, the CL flushes votes already when a frame becomes inactive,
> i.e., enters the BFcache. This part of the CL is behind a Finch flag.
> Before this CL, when a bfcached frame stayed around until the
> WebContents was destroyed, no votes could be sent because the
> AutofillCrowdsourcingManager would be destroyed with the WebContents.
>
> Thirdly, the dependency on AutofillDriver instead of BAM is another
> small step towards making BAM per-tab.
>
> Bug: 374086145, 40284887
> Change-Id: I875dc91f2489d7370eefe04e9869bc6e0f248f68
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6061418
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Commit-Queue: Christoph Schwering <schwering@google.com>
> Cr-Commit-Position: refs/heads/main@{#1393122}

Bug: 374086145, 40284887
Change-Id: I96551cfb4ea848d30d110f30599511273301e663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6076172
Commit-Queue: Christoph Schwering <schwering@google.com>
Reviewed-by: Andy Phan <andyphan@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1393274}