Reland "PA: Invert MiraclePtr Platform Enablement Logic" This reverts commit 19b5dd0c20337d8e914f83145b42d87243eb82b0. Reason for reland: I re-invert the DPD condition in patchset 2 Original change's description: > Revert "PA: Invert MiraclePtr Platform Enablement Logic" > > This reverts commit c3e9990871416987bd6c9d30624e4b6fa0b5e4bc. > > Reason for revert: I just realize I inverted the DPD condition > causing it to be enabled in non dcheck builds. > > Original change's description: > > PA: Invert MiraclePtr Platform Enablement Logic > > > > This patch inverts the build flags logic from an "allowlist" of platform > > toward a "deny list". > > > > - **Increased Confidence**: Guarantees MiraclePtr is active everywhere > > unless explicitly disabled, reducing the risk of unexpected > > vulnerabilities on niche platforms. > > > > - **Future-Proofing**: Potentially new platforms automatically inherit > > MiraclePtr from the beginning, eliminating the need to "ship" it one > > more time. > > > > - **Simplified Maintenance**: Focus shifts to maintaining a small, > > explicit list of exceptions rather than a growing list of enabled > > platforms. > > > > What is the "complementary"? > > ----------------------------- > > > > We know from `//build/config/BUILDCONFIG` the current_os is limited to: > > aix , android , chromeos > > fuchsia , ios , linux > > mac , nacl , win > > winuwp , zos > > > > "aix" and "zos" aren't supported by Chrome, only V8. So they can be > > ignored. > > > > Bug: 364466913 > > Change-Id: Ia03f8f18a4b3bb05e4c9d304980cadcf235be3c5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837217 > > Reviewed-by: Keishi Hattori <keishi@chromium.org> > > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > > Reviewed-by: Wez <wez@chromium.org> > > Reviewed-by: danakj <danakj@chromium.org> > > Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1352670} > > Bug: 364466913 > Change-Id: I7ed0231bfa46b2091041df6ef7c09a7726cfacc1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5844793 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Arthur Sonzogni <arthursonzogni@chromium.org> > Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1352693} Bug: 364466913 Change-Id: I315ccb248b5d6323849883aad085c93db218d2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5844931 Reviewed-by: danakj <danakj@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/main@{#1354441}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.