Fix applicable scope of Internals::setForcedColorsAndDarkPreferredColorScheme()

Previously the function had a local ColorSchemeHelper which resets
color scheme settings when it destructs, so the forced color flag
only applied to the UpdateAllLifecyclePhasesForTest() in the
function. This causes problems such as
1. If the test runs more document lifecycles (which may be arbitrary
   depending on the scheduler or the test runner), the forced color
   won't apply;
2. Composited scrollbars are not updated with the forced color because
   they are repainted in cc after blink's BeginMainFrame-triggered
   document lifecycle update.

Now store ColorSchemeHelper as an optional field of Internals. After
it's emplaced, it will destruct and restore color scheme settings
when the page unloads.

fast/forms/color-scheme/scrollbar/dynamic-color-scheme-change.html is
modified to include an explicit composited scrolling case, with
rebaselines. The old baseline contained wrong rendering of composited
scrollbars with wrong color schemes.

Bug: 40778657
Change-Id: Ic6c3797198c606231b4f7bfad96729aa39230c4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5311652
Reviewed-by: Gaston Rodriguez <gastonr@microsoft.com>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263496}
14 files changed
tree: 71a79edcea770d26ffe421cb8794aa2ca64a9fa8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.