Google Git
Sign in
chromium / chromium / src / 64c79ca65b0f3650cf41f3d8909106e676be58e0
commit64c79ca65b0f3650cf41f3d8909106e676be58e0[log] [tgz]
authorVictor Hugo Vianna Silva <victorvianna@google.com>Wed Jul 31 19:17:02 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 31 19:17:02 2024
tree2b7bd626b0ec8c2000eb889213e239978ed11634
parent0084b4dcd78948f9135011c461cb95aada4a5abd [diff]
[passswords] Add GetLocalUpmMinGmsVersion() which handles auto/non-auto

No behavior change.
Before this CL, there were 2 constants kLocalUpmMinGmsVersion and
kLocalUpmMinGmsVersionForAuto, and the logic to choose between the
2 was duplicated. This CL moves the logic to a single helper
GetLocalUpmMinGmsVersion(). The helper and kAccountUpmMinGmsVersion
are moved to a new file, since they don't fit password_features.h.

Note 1: this was already reviewed in crrev.com/c/5621244.

Note 2: a similar thing could be done for kLocalUpmMinGmsVersionParam
and kLocalUpmMinGmsVersionParamForAuto, but these feature parameters
will be removed in next CLs, so they are left as is.

Bug: 346556567
Change-Id: I820b10e09740b162123f8db47429fb3d0d7f8aa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5752606
Auto-Submit: Victor Vianna <victorvianna@google.com>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1335614}
4 files changed
tree: 2b7bd626b0ec8c2000eb889213e239978ed11634
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.