commit | 64e4e95f70ef8e493e64b459751c466419a6a29d | [log] [tgz] |
---|---|---|
author | Nina Satragno <nsatragno@chromium.org> | Thu Jan 20 16:08:28 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 20 16:08:28 2022 |
tree | 03cf2273050948c09bcef120980e55b3fc552b64 | |
parent | a72b289d9d583d8dc145a713363a0152e71e37d2 [diff] |
Revert "Report post-mouseover LCP as an LCP type" This reverts commit 010f919f101748abe5646df624c82e8f2a141363. Reason for revert: tests are flaky See bugs. Bug: 1289170, 1289218, 1289219 Original change's description: > Report post-mouseover LCP as an LCP type > > It seems like we have an issue with zoom widgets triggered by a > mouseover event over a previous <img>-based LCP image. > Such widgets are loading larger-than-current-LCP images, and since > moving the mouse doesn't count as an interaction, those LCP are > counted. > That goes against the goal of LCP to be a stable metric that doesn't > change based on user actions. > > At the same time, it's not currently clear what the impact of this is on > CrUX results. This CL will enable us to get a better understanding of > when this scenario happens, and what is its impact when it does. > > Change-Id: Ic761efa9e010cd27dc6fa17565cdd7b102013f16 > Bug: 1288027 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3395315 > Reviewed-by: Nicolás Peña <npm@chromium.org> > Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> > Cr-Commit-Position: refs/heads/main@{#961341} Bug: 1288027 Change-Id: Iee77aa4036b256059a96a529ac9f9c26e84336df No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3404695 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Owners-Override: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/main@{#961473}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.