Google Git
Sign in
chromium / chromium / src / 652cec85b84c96bf9b98a5958e767edebcc1bf26
commit652cec85b84c96bf9b98a5958e767edebcc1bf26[log] [tgz]
authorThomas Lukaszewicz <tluk@chromium.org>Mon May 26 19:07:54 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 26 19:07:54 2025
tree6888cd9f95b81dce925721cdca59b18be4d5d2f8
parent77504bc05a8714363aebda3c6d8e7ec972b77da8 [diff]
[bedrock] Clean up TabSearchToolbarButtonController

TabSearchToolbarButtonController is implemented as a controller
hosted on the BrowserWindowFeatures class. This is created shortly
after BrowserView construction and destroyed as the first action
during BrowserView destruction.

Currently BrowserView attempts to remove the controller's
observation of the TabSearchBubbleHost later in the BrowserView
destructor. However at this point the controller itself has
already been destroyed (reset as the first action in ~BrowserView).

This CL updates TabSearchToolbarButtonController to observe the
TabSearchBubbleHost shortly after BrowserView::Init() (in the
BrowserWindowFeatures::InitPostWindowConstruction() lifecycle
hook).

A scoped observation is used to ensure the observer is removed
as soon as TabSearchToolbarButtonController is reset.

BrowserView::GetBrowserViewForBrowser() is used in this CL avoid
crashes in "browser" unit tests. This will be removed shortly
after BrowserWithTestWindowTest is removed.

Bug: 413168662, 360163254
Change-Id: I9d0eea255d216eb81ebf0731c5b202a75d0a925b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6585653
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Commit-Queue: Tom Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1465620}
4 files changed
tree: 6888cd9f95b81dce925721cdca59b18be4d5d2f8
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.