Remove optional from FIDO request options (1/2) This CL makes FIDO request options parameters in the UnmaskDetails and UnmaskResponseDetails a base::Value::Dict instead of an std::optional<base::Value::Dict>. This is preferred because base::Value::Dict's can check if they are empty, and can be cleared, so it is more readable to use that instead of an optional. This is CL #1 of 2 in a chain of CLs that are intended to fix the FIDO enrollment flow. Converting FIDO request options to non-optionals will make the next CL in the chain much more readable by removing an extra empty check. Bug: 40207638 Change-Id: I45117a773493a8b2fd7e16de47c510f3eac5dd8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5542027 Reviewed-by: Olivia Saul <jsaul@google.com> Commit-Queue: Vinny Persky <vinnypersky@google.com> Reviewed-by: Siyu An <siyua@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1303462}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.