Google Git
Sign in
chromium / chromium / src / 6542ac98bbbeb8cd7a1604af644f0a671538ba18
commit6542ac98bbbeb8cd7a1604af644f0a671538ba18[log] [tgz]
authorElitsa Bankova <elitsa@google.com>Mon Aug 21 01:09:05 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Aug 21 01:09:05 2023
tree61b9656d704b5e99ed8ff6a640d791a8006b3421
parent4eafcdf27d07077012ebd8a37c58db2aafe13841 [diff]
Reland "Base: Update Hardware model name function to match description"

This is a reland of commit 58165410c4396455a19e1069d9563ad2618ea5ee

Fixing broken test that didn't run in the presubmit.

Original change's description:
> Base: Update Hardware model name function to match description
>
> According to the function description, the hardware model name should be
> empty if the machine model is unknown but currently in the ChromeOS
> version it returns "UNKNOWN". Updating only the ChromeOS version.
>
> Bug: b/293242135
> Change-Id: I301cd14b43df06cea7249e68e192af39ab6c7921
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4746419
> Commit-Queue: Elitsa Bankova <elitsa@google.com>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Reviewed-by: Chloe Pelling <cpelling@google.com>
> Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1180654}

Bug: b/293242135
Change-Id: I427e2cfc79e81a251b265709fe77327b34be502c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4763948
Reviewed-by: Callistus Tan <callistus@google.com>
Commit-Queue: Elitsa Bankova <elitsa@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Chloe Pelling <cpelling@google.com>
Cr-Commit-Position: refs/heads/main@{#1185673}
4 files changed
tree: 61b9656d704b5e99ed8ff6a640d791a8006b3421
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.