Google Git
Sign in
chromium / chromium / src / 65bfa9e7d9367e9be2ce01d00559e57c98c392af
commit65bfa9e7d9367e9be2ce01d00559e57c98c392af[log] [tgz]
authorAndre Le <leandre@chromium.org>Wed Nov 10 19:28:19 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Nov 10 19:28:19 2021
tree9df8f3a39930168cf2e5349275e05fce84652861
parentdaaa371ee6a3037c69946e0791b476f385a967fc [diff]
Reland "NotificationRevamp: Fix screenshot notification."

This is a reland of 82963480929e2b3e58a2dca08f18f7d2726a41e7. Besides the reland, this added overridden functions to capture mode notification so that `extra_view_` is properly destructed.

Original change's description:
> NotificationRevamp: Fix screenshot notification.
>
> With the new refactor to NotificationViewBase's image_container_view_,
> CaptureModeNotificationView now only needs to create extra view in ctor
> and there's no need to have view observer. Removing these view observers
> also fixes the layout issue with extra view.
>
> This CL also added rounded corners for the banner view in the new
> notification.
>
> Bug: 1266583
> Change-Id: I890c26756cb62e457de754f88ebf1f332cc69ac8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3268169
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Commit-Queue: Andre Le <leandre@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#939569}

Bug: 1266583
Change-Id: I4be2c5ba540a8cdeb921bd59b0c54838cb3a8564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3271171
Commit-Queue: Andre Le <leandre@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940426}
5 files changed
tree: 9df8f3a39930168cf2e5349275e05fce84652861
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.