commit | 66124aefd6725ef36f374858c6a41a45315d7139 | [log] [tgz] |
---|---|---|
author | Xinghui Lu <xinghuilu@chromium.org> | Sat Jan 06 01:46:34 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Jan 06 01:46:34 2024 |
tree | 9140c7173b3bbaa9c5484eaed5ae4e7c2a1b0871 | |
parent | 8aec6aba79956ada6ecee197c9526f3790019efd [diff] |
Reland "Pass in has_post_commit_interstitial_skipped into AsyncCheckTracker" This is a reland of commit aba147eb8b184df683e2702ef4b1e30f32d3cb18. This was not caught initially because https://crrev.com/c/5160893 was landed right before this CL and the CQ+1 got carried over since there is no merge conflict. Diff can be found between Patchset1 and Patchset2. Original change's description: > Pass in has_post_commit_interstitial_skipped into AsyncCheckTracker > > If post commit interstitial is skipped because of uncommitted > navigation, AsyncCheckTracker will trigger the interstitial when > DidFinishNavigation is called. The has_post_commit_interstitial_skipped > bit is passed from the callback in UnsafeResource. > > Bug: 1501194 > Change-Id: I46a59f7068234b5e0dcec3e7561d35d947e09dcc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5148068 > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Reviewed-by: thefrog <thefrog@chromium.org> > Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Reviewed-by: Ali Juma <ajuma@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1242983} Bug: 1501194 Change-Id: I2b0436c64832b6fbe37d8a73a9f3e22493d241ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5169817 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Carlos IL <carlosil@chromium.org> Reviewed-by: thefrog <thefrog@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/main@{#1243713}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.