commit 661d86b2ab80df8b4c9969f1336ce580bd26950f
author Alex Ilin <alexilin@chromium.org> Mon Oct 18 11:33:13 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Oct 18 11:33:13 2021
tree beef898129077fb36ec59b923fe0efd7128a7356
parent 4705df08f2b86348af6291390b4e92335671261d

Reland "[Lacros] Do not create AccountProfileMapper if the feature is off"

This is a reland of 7db902da0f7ad90b013f69e005957e22909ac13e with a fix
for a crash.

The reason of crash is that an AccountProfileMapper could be destroyed
before a profile that this has dependency on it. This problem is
addressed by changing the order of class member declaration in
profile_manager.h.

Original change's description:
> [Lacros] Do not create AccountProfileMapper if the feature is off
>
> AccountProfileMapper should only be created if the
> kMultiProfileAccountConsistency feature is enabled. Otherwise, it might
> have negative side-effects like deleting user profiles.
>
> To add a DCHECK(kMultiProfileAccountConsistency) to
> AccountProfileMapper,
> this CL also enables kMultiProfileAccountConsistency in all related
> unit tests. This appears to be a non-trivial task because ProfileManager
> will now create its own instance of AccountProfileMapper that doesn't
> use an AccountManagerFacade mock.
>
> This CL adds a TestingProfileManager::SetAccountProfileMapper() methods
> to inject a fake instance for testing.
>
> Bug: 1226045
> Change-Id: I69f74aed3f4bd9bdb107912d5e92872d53691a07
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222809
> Reviewed-by: David Roger <droger@chromium.org>
> Commit-Queue: Alex Ilin <alexilin@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#931942}

Bug: 1226045
Change-Id: I3a61f396e3f3c6ea423b0845525e3fbfdbd1258d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225895
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932477}