commit | 6628ad4178f629f8d78406568e022520c1cfa702 | [log] [tgz] |
---|---|---|
author | CGQAQ <m.jason.liu@gmail.com> | Thu Mar 20 00:20:07 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 20 00:20:07 2025 |
tree | dd7a13383531de3a1121a21928072b245196c894 | |
parent | d6eec59f6403a5d9e847ea813040d3280e3bb031 [diff] |
Fix the background color animation between color spaces. srgb and oklch are not behaving correctly. This CL fixes when `background-color` and the one in keyframes is `no-legacy` and `legacy` color space mixed, they will end-up been interpolate as oklab with sRGBLegacy. In particular `oklch(45% 0.2 264)` is treated as non-legacy so has been converted into `oklab(45% -0.02 -0.2)`, but the original `background-color` is in hex format, will keep as is(sRGBLegacy), and These two colors are blending with sRGBLegacy mode; that is why we only see r component is changing, the other two components are always 0 in devtools, because they are mixing togather with different expectations. One want to interpolate with oklab but the other want to interpolate with sRGB. Bug: 341132088 Change-Id: Ic0d72f2189b71a22d8f33104e486c868c8af849e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6354303 Commit-Queue: Jason Leo <m.jason.liu@gmail.com> Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Auto-Submit: Jason Leo <m.jason.liu@gmail.com> Cr-Commit-Position: refs/heads/main@{#1435188}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.