commit 66759752273c0966338d488e7df917f9166e1b02
author Will Harris <wfh@chromium.org> Thu Jun 06 15:33:13 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jun 06 15:33:13 2024
tree 17ca5a67d6a71a27f30c4272e63442093b5138a8
parent 8d648ebd5eb84e69b46eac041bc47fc0e1bef7eb

Revert "Use unique App Container ids for each instance of a browser test."

This reverts commit bab0ea3f555e619055346a1df492452c08a7107e.

Reason for revert: could be causing arm64 bot failures

This revert will re-introduce flakes but that's been decided
is better than the current situation where the additional
app container profiles can cause some arm64 bots to completely
fail due to an issue with the Windows API in use.

Subsequent CLs will investigate other options for preventing
the flakes from happening in the first place, without causing
as much negative impact on arm64 bots.

Note: this is not a clean revert, see PS 1..4 for diff.

Original change's description:
> Use unique App Container ids for each instance of a browser test.
>
> There is a race condition in CreateAppContainerProfile which can cause
> two non-cooperating processes trying to create the identically named
> app container profile to fail non-deterministically.
>
> This is not a problem in production because this never happens as
> Chrome maintains a singleton instance to prevent multiple Chrome
> browsers running at the same time pointed to the same App-Container
> profile.
>
> However, in tests, they can run at the same time causing this to
> occasionally trigger as seen in the attached bug.
>
> This CL fixes this by, in tests only, appending the data dir which is
> unique for each test instance, to the App Container profile name.
>
> This (longer) name is later SHA1 hashed by the sandbox code to
> generate the unique App Container profile name.
>
> It is hoped this CL will eliminate the current flakes on the CQ and CI
> while keeping production/Chrome functionality the same as we have not
> seen this issue occur in the wild.
>
> No functional changes in production/shipping code are intended
> by this CL.
>
> BUG=40223285
>
> Change-Id: I85f6eee2f9079f2673620fdfdbd24dfe6a0e184f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468745
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Will Harris <wfh@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1290236}

Bug: 40223285, 342424178
Change-Id: I556d952aa21dec2e0970d71b407ecb47d8cf6cfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5583201
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1311284}